feat(otelcol/connector/servicegraph): add virtual_node_peer_attributes setting to the component
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` setting to the component Signed-off-by: hainenber <[email protected]>
wildum
reviewed
May 22, 2024
docs/sources/reference/components/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
Co-authored-by: William Dumont <[email protected]>
Signed-off-by: hainenber <[email protected]>
|
waiting for @clayton-cornell feedback on the doc before merging it |
docs/sources/reference/components/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
ptodev
reviewed
May 28, 2024
docs/sources/reference/components/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
…telcol-connector-servicegraph
Co-authored-by: Paulin Todev <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Signed-off-by: hainenber <[email protected]>
…telcol-connector-servicegraph
|
All fine by me :D |
| @@ -107,6 +108,19 @@ Additional labels can be included using the `dimensions` configuration option: | |||
|
|
|||
| When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces. | |||
|
|
|||
| `virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented. | |||
There was a problem hiding this comment.
Suggested change
| `virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented. | |
| `virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service that is not OTel-instrumented. |
|
|
||
| If no client span is found and `virtual_node_peer_attributes` is not an empty list, | ||
| then the service span will be paired with a virtual node called `client="user"`. | ||
| This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service. |
There was a problem hiding this comment.
Suggested change
| This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service. | |
| This can be useful when a client that is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service. |
| @@ -107,6 +108,19 @@ Additional labels can be included using the `dimensions` configuration option: | |||
|
|
|||
| When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces. | |||
|
|
|||
| `virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented. | |||
| Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span, | |||
There was a problem hiding this comment.
Suggested change
| Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span, | |
| Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span |
|
This PR has not had any activity in the past 30 days, so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add the virtual_node_peer_attributes setting to otelcol.connector.servicegraph. Thanks @erikbaranowski for creating the foundation already!
The default attributes are reduced to be identical to upstream
Which issue(s) this PR fixes
Closes #861
Notes to the Reviewer
PR Checklist