Expose host property from prometheus/common #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
| @@ -32,6 +32,7 @@ Name | Type | Description | |||
| `proxy_from_environment` | `bool` | Use the proxy URL indicated by environment variables. | `false` | no | |||
| `proxy_connect_header` | `map(list(secret))` | Specifies headers to send to proxies during CONNECT requests. | | no | |||
| `follow_redirects` | `bool` | Whether redirects returned by the server should be followed. | `true` | no | |||
| `host` | `string` | Override HTTP hostname | | no | |||
There was a problem hiding this comment.
Suggested change
| `host` | `string` | Override HTTP hostname | | no | |
| `host` | `string` | Override HTTP hostname. | | no |
For consistency, we should add a full stop (period) at the end of this description. This should be cascaded to to all instances of Override HTTP hostname.
|
Over to @grafana/grafana-alloy-maintainers for code review |
clayton-cornell
added
the
type/docs
rfratto
added
the
backport-to-agent:no
|
Ping for review? @grafana/grafana-agent-maintainers |
ptodev
reviewed
Jun 6, 2024
| @@ -92,6 +93,7 @@ func (h *HTTPClientConfig) Convert() *config.HTTPClientConfig { | |||
| FollowRedirects: h.FollowRedirects, | |||
| EnableHTTP2: h.EnableHTTP2, | |||
| ProxyConfig: h.ProxyConfig.Convert(), | |||
| Host: h.Host, | |||
There was a problem hiding this comment.
@jkroepke It looks like Host got removed from the upstream repo.
There was a problem hiding this comment.
yes, see prometheus/common#645
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In prometheus/common#549 I add the possibility to define a custom HTTP header. I would like to use that feature in Grafana Alloy as well.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist