-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing go mod replace for collector/service
and collector/otelcol
#1023
Conversation
This copying is not "a little", but I think it's still better than the go mod replace 😄 |
This PR has not had any activity in the past 30 days, so the |
6689dfb
to
b51d740
Compare
// https://github.com/open-telemetry/opentelemetry-collector/issues/4970 | ||
replace ( | ||
go.opentelemetry.io/collector/otelcol => github.com/grafana/opentelemetry-collector/otelcol v0.0.0-20241104164848-8ea9d0a3e17a | ||
go.opentelemetry.io/collector/processor/batchprocessor => github.com/grafana/opentelemetry-collector/processor/batchprocessor v0.0.0-20241104164848-8ea9d0a3e17a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the batch processor replace too, because this change has been merged: #2027
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic LGTM, I didnt look to closely at the forked code assumed it was the same.
To avoid copied code, I reimplemented the feature using the exported tools otelcol expects you to use in this other PR: #2148 |
Closing this PR in favour of #2148, which doesn't require copying code 🥳 |
In the spirit of "a little copying is better than a little dependency."....
I will also make a similar change to Agent. However, in the Agent I think we will still need the "service" package to be replaced so that we can embed the OTel Collector's metrics in the Agent's
/metrics
endpoint.