Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a few outstanding items that I haven't managed to get working
[textfile_directory]
argument. When trying to specify a custom path (i.e.C:\Prometheus\Files
): escaping slashes threw an error with Alloy, and the service wouldn't start on Windows. I'm probably just missing something stupid here.[timeout]
attribute onprometheus.windows.exporter
threw an error when specified in config.I'll dig further into those, but the module works as-is currently, and supports the Windows Integration Dashboards in Grafana Cloud (Metric Queries Only).
I have a few other ideas for expanding this module out some more, but I'll get to those later.
additional_collectors
argument. Provide the ability to add collectors on top of the default one, without having to specify the whole default list again