Log: Add 'country' to geoip pipeline-stage #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Related to: grafana/loki#11378 |
clayton-cornell
added
the
type/docs
tpaschalis
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM! Thank you for the contribution @superstes and for prioritizing the Agent feature first! 🙌
|
@superstes I can't push to your branch :( The linter is complaining about the Could you please put them in a const to satisfy the linter so we can merge this? |
auto-merge was automatically disabled
December 9, 2023 20:52
Head branch was pushed to by a user without write access
|
@tpaschalis Sorry - did not mean to block it. |
clayton-cornell
approved these changes
Dec 14, 2023
|
@tpaschalis @superstes The build is passing now, so I'll get this one merged :-) |
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* Add 'country' to log pipeline-stage geoip * Add tests for log pipeline-stage geoip * Add 'country' to log pipeline-stage geoip * Lint-fix for tests of pipeline-stage geoip
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Maxmind provides multiple GeoIP2 databases.
The three most used ones are City, Country and ASN as they are also available as free GeoLiteIP2 databases.
Some users might want/need to use the 'Country' database - so I added support for it.
A reason: If the user only has the 'Country' database licensed.
Notes to the Reviewer
I've now also added mmdb-specific tests.
To note: The minimal (1 record) testdata-databases are added for the sake of simplicity.
One could also:
PR Checklist