Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(flow/ref/comp): remove nonsensical ref in otelcol.processor.filter #5913

Conversation

hainenber
Copy link
Contributor

PR Description

Remove doc ref for a unusable ref for otelcol.processor.filter metric block

Which issue(s) this PR fixes

Fixes #5907

Notes to the Reviewer

PR Checklist

  • Documentation added

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.38 labels Dec 5, 2023
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @hainenber

@clayton-cornell clayton-cornell merged commit b7f7c57 into grafana:main Dec 5, 2023
12 checks passed
grafanabot pushed a commit that referenced this pull request Dec 5, 2023
clayton-cornell pushed a commit that referenced this pull request Dec 5, 2023
#5913) (#5914)

Signed-off-by: hainenber <[email protected]>
(cherry picked from commit b7f7c57)

Co-authored-by: Đỗ Trọng Hải <[email protected]>
@ptodev
Copy link
Contributor

ptodev commented Dec 5, 2023

It seems there are also some broken lines in the docs for otelcol.processor.filter such as these:

Screenshot 2023-12-05 at 18 06 53

I think they're meant to point to the same OTTL context links as these.

@clayton-cornell
Copy link
Contributor

Ooops... on it. A few slipped though in the last big update.

BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.38 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs feedback: /docs/sources/flow/reference/components/otelcol.processor.filter.md
3 participants