Flow Windows service: Support environment variables #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
mattdurham
reviewed
Nov 13, 2023
ptodev
reviewed
Nov 14, 2023
Comment on lines
+66
to
+67
| * `Arguments` (Type `REG_MULTI_SZ`) Each value represents a binary argument for grafana-agent-flow binary. | ||
| * `Environment` (Type `REG_MULTI_SZ`) Each value represents a environment value `KEY=VALUE` for grafana-agent-flow binary. |
There was a problem hiding this comment.
I think people might find it useful if we include a regedit printout of an example configuration. I don't insist on it, will leave it up to you to decide.
There was a problem hiding this comment.
Do you mean the output of reg query ?
There was a problem hiding this comment.
I guess so? I've only used reg export and I suppose reg query does a similar job. As long as people can see the values in a format they can recognise, it's ok.
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Co-authored-by: Robert Fratto <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
|
Is there anything from my side todo here? |
mattdurham
approved these changes
Nov 22, 2023
|
I fixed the Changelog entry, since 0.38 is released. |
clayton-cornell
added
the
type/docs
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Nov 25, 2023
* Implement windows service environment variabls Signed-off-by: Jan-Otto Kröpke <[email protected]> * Changelog Signed-off-by: Jan-Otto Kröpke <[email protected]> * Add NSIS argument * Always override Environment, since its an expected user input Signed-off-by: Jan-Otto Kröpke <[email protected]> * Update cmd/grafana-agent-service/config_windows.go Co-authored-by: Robert Fratto <[email protected]> * Update cmd/grafana-agent-service/config_windows.go * Update docs/sources/flow/setup/install/windows.md Co-authored-by: Clayton Cornell <[email protected]> * Update CHANGELOG.md --------- Signed-off-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: mattdurham <[email protected]> Co-authored-by: Robert Fratto <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Windows support environments for global, per user and per service. All three os native methods have downsides
I copied the replicate the Arguments logic for Environment. Environment are needed to inject configuration from outside. Define configuration via CLI argument is not supported (see: grafana/alloy#308)
Which issue(s) this PR fixes
Notes to the Reviewer
Tested on Windows Server 2022.
PR Checklist