Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus.scrape: clarify docs on job label #5680

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

captncraig
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@captncraig captncraig added the type/docs Docs Squad label across all Grafana Labs repos label Nov 1, 2023
@captncraig captncraig changed the title prometheus.scraps: clarify docs on job label prometheus.scrape: clarify docs on job label Nov 1, 2023
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much more understandable

@clayton-cornell clayton-cornell enabled auto-merge (squash) November 1, 2023 18:22
@clayton-cornell clayton-cornell merged commit c2ecec3 into main Nov 1, 2023
@clayton-cornell clayton-cornell deleted the cmp_clarify_job branch November 1, 2023 18:26
grafanabot pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)
grafanabot pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)
grafanabot pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)
clayton-cornell pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)

Co-authored-by: Craig Peterson <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)

Co-authored-by: Craig Peterson <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 1, 2023
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit c2ecec3)

Co-authored-by: Craig Peterson <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.35 backport release-v0.36 backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants