Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent Management: Small doc tweaks #5526

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Agent Management: Small doc tweaks #5526

merged 3 commits into from
Oct 19, 2023

Conversation

jcreixell
Copy link
Contributor

PR Description

  • Remove references to v2 in the API (this does not have much meaning to users).
  • Specify that agent_id is required when label management is enabled.

@jcreixell
Agent Management: Small doc tweaks
8665aa6 
- Remove references to v2 in the remote config endpoint (this does not have much meaning to users)
- Specify that `agent_id` is required when label management is enabled.
spartan0x117
spartan0x117 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what do you think about moving the agent_id section right underneath the label_management_enabled section to make it easier to find after reading the requirement?

@jcreixell jcreixell merged commit 08b9a23 into main Oct 19, 2023
7 checks passed
@jcreixell jcreixell deleted the am-doc-tweaks branch October 19, 2023 12:56
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spartan0x117 spartan0x117 spartan0x117 approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcreixell @spartan0x117