Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migrating-from-static.md #5516

Closed
wants to merge 2 commits into from
Closed

Update migrating-from-static.md #5516

wants to merge 2 commits into from

Conversation

mikempx
Copy link

@mikempx mikempx commented Oct 17, 2023

Running existing static to flow conversion with "grafana-agent" insinuated that I still needed the old agent. By default, the executable is named, "grafana-agent-flow" in the documentation and doesn't mention a need to rename the executable.

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Running existing static to flow conversion with "grafana-agent" insinuated that I still needed the old agent. By default, the executable is named, "grafana-agent-flow" in the documentation and doesn't mention a need to rename the executable.
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ clayton-cornell
❌ mikempx
You have signed the CLA already but the status is still pending? Let us recheck it.

@clayton-cornell
Copy link
Contributor

@erikbaranowski Can you take a look at this? Is this the right solution or is there something else going on here that we need to account for?

@clayton-cornell
Copy link
Contributor

@mikempx Can you sign the CLA whenyou get a chance :-)

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.37 labels Oct 17, 2023
@erikbaranowski
Copy link
Contributor

@clayton-cornell the converter will work with either binary. It requires the env var only for the grafana-agent binary since Flow mode is not the default. I'm comfortable with documenting it in the converter guides however makes sense for clarity and consistency.

@clayton-cornell
Copy link
Contributor

@erikbaranowski maybe we document it both ways?

If you're using Grafana Agent static mode: AGENT_MODE=flow grafana-agent convert --source-format=static --bypass-errors --output=OUTPUT_CONFIG_PATH INPUT_CONFIG_PATH

If you're using Grafana Agent flow mode: grafana-agent-flow convert --source-format=static --bypass-errors --output=OUTPUT_CONFIG_PATH INPUT_CONFIG_PATH

@erikbaranowski
Copy link
Contributor

I'm good with documenting both since we have done so in places like here: https://grafana.com/docs/agent/latest/flow/reference/cli/run/.

Let's update all 3 migration guides if we are making this change for consistency.

@clayton-cornell
Copy link
Contributor

@mikempx I'm going to close this PR. Your request resulted in a larger change to the docs than was implemented here and it was easier/faster and cleaner to open a new PR to take care of the change.

The new PR is: #5544

@clayton-cornell clayton-cornell deleted the mikempx-patch-1 branch October 19, 2023 21:52
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants