-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update migrating-from-static.md #5516
Conversation
Running existing static to flow conversion with "grafana-agent" insinuated that I still needed the old agent. By default, the executable is named, "grafana-agent-flow" in the documentation and doesn't mention a need to rename the executable.
|
@erikbaranowski Can you take a look at this? Is this the right solution or is there something else going on here that we need to account for? |
@mikempx Can you sign the CLA whenyou get a chance :-) |
@clayton-cornell the converter will work with either binary. It requires the env var only for the grafana-agent binary since Flow mode is not the default. I'm comfortable with documenting it in the converter guides however makes sense for clarity and consistency. |
@erikbaranowski maybe we document it both ways? If you're using Grafana Agent static mode: If you're using Grafana Agent flow mode: |
I'm good with documenting both since we have done so in places like here: https://grafana.com/docs/agent/latest/flow/reference/cli/run/. Let's update all 3 migration guides if we are making this change for consistency. |
Running existing static to flow conversion with "grafana-agent" insinuated that I still needed the old agent. By default, the executable is named, "grafana-agent-flow" in the documentation and doesn't mention a need to rename the executable.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist