fix issue with non utf8 encodings and environment variable expansion #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an utfX file. Now we convert all to utf8.
erikbaranowski
approved these changes
Oct 17, 2023
rfratto
reviewed
Oct 17, 2023
rfratto
reviewed
Oct 17, 2023
…agent into windows_nonutf8_encoding_envvar
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This converts all configs to UTF8. It doesnt attempt to try every combo of encodings but the most common ones: ascii, utf8bom/nobom, utf16le bom/nobom, and utf32bom/nobom.
Which issue(s) this PR fixes
Closes #4519
Notes to the Reviewer
PR Checklist