Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GlobalRefMap into service instead of global var. #5489

Merged
merged 17 commits into from
Oct 24, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
mattdurham committed Oct 16, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 6028c69b6a2987ae2f82d391b02f8226d344f5d6
3 changes: 1 addition & 2 deletions pkg/flow/componenttest/componenttest.go
Original file line number Diff line number Diff line change
@@ -4,12 +4,12 @@ package componenttest
import (
"context"
"fmt"
"github.com/grafana/agent/service/labelstore"
"os"
"reflect"
"sync"
"time"

"github.com/grafana/agent/service/labelstore"
"github.com/prometheus/client_golang/prometheus"
"go.opentelemetry.io/otel/trace"
"go.uber.org/atomic"
@@ -161,7 +161,6 @@ func (c *Controller) buildComponent(dataPath string, args component.Arguments) (
Registerer: prometheus.NewRegistry(),
GetServiceData: func(name string) (interface{}, error) {
return labelstore.New(nil), nil

},
}