Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make namespace and server optional in discovery nomad #5488

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Make namespace and server optional in discovery nomad #5488

merged 4 commits into from
Oct 16, 2023

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Oct 16, 2023

PR Description

Fields namespace and server from discovery.nomad have a default value but
the fields where marked as required. This PR fixes the issue.

Which issue(s) this PR fixes

Fixes #5479

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@marctc marctc requested a review from a team as a code owner October 16, 2023 14:00
spartan0x117
spartan0x117 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docs/sources/flow/reference/components/discovery.nomad.md's Usage section may also need to be updated to remove the non-required server argument?

But LGTM!

@marctc marctc enabled auto-merge (squash) October 16, 2023 15:01
@marctc marctc merged commit d84fe30 into main Oct 16, 2023
7 checks passed
@marctc marctc deleted the fix_nomad_defaults branch October 16, 2023 15:05
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spartan0x117 spartan0x117 spartan0x117 approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs feedback: /docs/sources/flow/reference/components/discovery.nomad.md
2 participants
@marctc @spartan0x117