-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): render index.md's admonition link #5478
fix(doc): render index.md's admonition link #5478
Conversation
Signed-off-by: hainenber <[email protected]>
@jdbaldry Can you take a quick look at this. I should have done a make doc build test before I merged the last PR that was raised to fix this link. The Previous PRs
This also look broken in v0.36 (wasn't fixed in v0.36 in the previous PRs) |
Agh, sorry for this. I discovered that the Markdown parser does not appreciate whitespace in link definitions. If possible, the best fix is to replace |
@hainenber I'm going to apply the suggestions and push this fix through. I don't wan tit to lag behind too much and I need the topic fixed for other incoming updates :-) Thanks for spotting this. It's lead to fixing a similar problem in a few other places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. The same fix has been applied already to v0.37 and v0.36 docs.
PR Description
Which issue(s) this PR fixes
Fixes issue shown in following screenshot. Captured in https://grafana.com/docs/agent/latest/
Notes to the Reviewer
PR Checklist