Fix an issue with the static to flow converter for blackbox exporter … #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules config not being included in the river output. Signed-off-by: erikbaranowski <[email protected]>
erikbaranowski
commented
Oct 13, 2023
|
|
||
| func TestUnmarshalRiverWithInlineConfigYaml(t *testing.T) { | ||
| riverCfg := ` | ||
| config = "modules:\n http_2xx:\n prober: http\n timeout: 5s\n" |
There was a problem hiding this comment.
I decided to include this similar test since it validates and demonstrates the traditional yaml format in use for this argument.
rfratto
approved these changes
Oct 13, 2023
| ProbeTimeoutOffset float64 `yaml:"probe_timeout_offset,omitempty"` | ||
| BlackboxConfigFile string `yaml:"config_file,omitempty"` | ||
| BlackboxTargets []BlackboxTarget `yaml:"blackbox_targets"` | ||
| BlackboxConfig util.RawYAML `yaml:"blackbox_config,omitempty"` |
There was a problem hiding this comment.
As an aside:
This would normally be the kind of thing which would be a breaking change to the code API. To me, that's re-enforcing the idea of putting everything in internal/ for 1.0 until we're ready to pick a subset of packages to expose.
tpaschalis
pushed a commit
to tpaschalis/agent
that referenced
this pull request
Oct 16, 2023
…modules (grafana#5476) config not being included in the river output. Signed-off-by: erikbaranowski <[email protected]> (cherry picked from commit 04b90c6)
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…modules
config not being included in the river output.
PR Description
Which issue(s) this PR fixes
Fixes #5451
Notes to the Reviewer
PR Checklist