Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update architecture.md #4642

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Update architecture.md #4642

merged 3 commits into from
Dec 8, 2023

Conversation

arunkg2787
Copy link
Contributor

Fixes #https://github.com/grafana/support-escalations/issues/5907

Architecture : Added k8s example of sharding and replication

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for the docs.

docs/sources/operator/architecture.md Outdated Show resolved Hide resolved
docs/sources/operator/architecture.md Outdated Show resolved Hide resolved
docs/sources/operator/architecture.md Outdated Show resolved Hide resolved
docs/sources/operator/architecture.md Outdated Show resolved Hide resolved
docs/sources/operator/architecture.md Outdated Show resolved Hide resolved
Comment on lines 153 to 174
```
apiVersion: apps/v1
kind: Deployment
metadata:
name: grafana-agent
spec:
replicas: 3
selector:
matchLabels:
app: grafana-agent
template:
metadata:
labels:
app: grafana-agent
spec:
containers:
- name: grafana-agent
image: grafana/agent:latest
args:
- "--shards=3"
- "--replicas=2"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For alignment, this (and the following example code block) should be indented to align with the first char of the bullet the precedes it. This will align the code block with the bullet text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Will use this in the future. If that's ok, I'd like to merge the PR so we cut down on the queue of open PRs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

This PR has been automatically marked as stale because it has not had any activity in the past 30 days. The PR will not be closed automatically, but a label will be added to it for tracking purposes.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Sep 1, 2023
@tpaschalis
Copy link
Member

@arunkg2787 could you please take a look at @clayton-cornell 's suggestions?

@github-actions github-actions bot removed the stale Issue/PR mark as stale due lack of activity label Sep 5, 2023
arunkg2787 and others added 3 commits December 8, 2023 16:13
Fixes #grafana/support-escalations#5907

Architecture : Added k8s example of sharding and replication
Signed-off-by: Paschalis Tsilias <[email protected]>
@tpaschalis tpaschalis enabled auto-merge (squash) December 8, 2023 14:14
@tpaschalis tpaschalis merged commit 2201871 into main Dec 8, 2023
11 checks passed
@tpaschalis tpaschalis deleted the arunkg2787-patch-2 branch December 8, 2023 14:18
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Paschalis Tsilias <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants