-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update architecture.md #4642
Update architecture.md #4642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions for the docs.
``` | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
metadata: | ||
name: grafana-agent | ||
spec: | ||
replicas: 3 | ||
selector: | ||
matchLabels: | ||
app: grafana-agent | ||
template: | ||
metadata: | ||
labels: | ||
app: grafana-agent | ||
spec: | ||
containers: | ||
- name: grafana-agent | ||
image: grafana/agent:latest | ||
args: | ||
- "--shards=3" | ||
- "--replicas=2" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For alignment, this (and the following example code block) should be indented to align with the first char of the bullet the precedes it. This will align the code block with the bullet text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! Will use this in the future. If that's ok, I'd like to merge the PR so we cut down on the queue of open PRs.
This PR has been automatically marked as stale because it has not had any activity in the past 30 days. The PR will not be closed automatically, but a label will be added to it for tracking purposes. |
@arunkg2787 could you please take a look at @clayton-cornell 's suggestions? |
Fixes #grafana/support-escalations#5907 Architecture : Added k8s example of sharding and replication
Co-authored-by: Clayton Cornell <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
0d6556b
to
a50cca6
Compare
Signed-off-by: Paschalis Tsilias <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]>
Fixes #https://github.com/grafana/support-escalations/issues/5907
Architecture : Added k8s example of sharding and replication
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist