Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite all front matter as YAML with current alias defined #1705

Merged
merged 1 commit into from
May 16, 2022

Conversation

jdbaldry
Copy link
Member

PR Description

The addition of the current alias has no effect on the website as Hugo
will not create an HTML redirect if there is already content in the
web server directory.

The reason for the addition of the alias is to reduce the likelihood
of 404s occuring when files are moved.

Signed-off-by: Jack Baldry [email protected]

Notes to the Reviewer

PR Checklist

  • [na] CHANGELOG updated
  • [na] Documentation added
  • [na] Tests updated

The addition of the current alias has no effect on the website as Hugo
will not create an HTML redirect if there is already content in the
web server directory.

The reason for the addition of the alias is to reduce the likelihood
of 404s occuring when files are moved.

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry requested a review from brendamuir as a code owner May 16, 2022 09:29
@jdbaldry jdbaldry requested a review from a team May 16, 2022 09:29
---
aliases:
- /docs/agent/latest/README/
draft: "True"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is working on the website. https://grafana.com/docs/agent/latest/README/ is a 404. I was expecting this to be a boolean value though.

@brendamuir brendamuir merged commit 5086ffc into main May 16, 2022
@brendamuir brendamuir deleted the jdb/2022-05-rewrite-front-matter-as-YAML branch May 16, 2022 12:37
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants