Add delay that is 3 x heartbeat for scraping service in the config wa… #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcher to ensure there isnt a race condition in a node being unhealthy but owning configs.
captncraig
pushed a commit
that referenced
this pull request
May 2, 2022
#1663) * Add delay that is 3 x heartbeat for scraping service in the config watcher to ensure there isnt a race condition in a node being unhealthy but owning configs. * Trigger CI build
Merged
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add delay to prevent a race condition, it's using a hammer to fix something that could be more elegantly solved.
Which issue(s) this PR fixes
This hopefully explains it
https://gist.github.com/mattdurham/c15f27de17a6da97bf2e6a870991c7f2
Notes to the Reviewer
PR Checklist