Add HTTPClientConfig to discovery.ec2 and add a simple test

CHANGELOG.md

@@ -101,6 +101,8 @@ Main (unreleased)
 
 - Improved resilience of graph evaluation in presence of slow components. (@thampiotr)
 
+- Allow overriding `HTTPClientConfig` fields such as `proxy_url` in `discovery.ec2`. (@cmbrad)
+
 ### Bugfixes
 
 - Set exit code 1 on grafana-agentctl non-runnable command. (@fgouteroux)

component/discovery/aws/ec2.go

@@ -7,6 +7,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws/ec2metadata"
 	"github.com/aws/aws-sdk-go/aws/session"
 	"github.com/grafana/agent/component"
+	"github.com/grafana/agent/component/common/config"
 	"github.com/grafana/agent/component/discovery"
 	"github.com/grafana/river/rivertypes"
 	promcfg "github.com/prometheus/common/config"
@@ -42,18 +43,21 @@ type EC2Arguments struct {
 	RefreshInterval time.Duration     `river:"refresh_interval,attr,optional"`
 	Port            int               `river:"port,attr,optional"`
 	Filters         []*EC2Filter      `river:"filter,block,optional"`
+
+	HTTPClientConfig config.HTTPClientConfig `river:",squash"`
 }
 
 func (args EC2Arguments) Convert() *promaws.EC2SDConfig {
 	cfg := &promaws.EC2SDConfig{
-		Endpoint:        args.Endpoint,
-		Region:          args.Region,
-		AccessKey:       args.AccessKey,
-		SecretKey:       promcfg.Secret(args.SecretKey),
-		Profile:         args.Profile,
-		RoleARN:         args.RoleARN,
-		RefreshInterval: model.Duration(args.RefreshInterval),
-		Port:            args.Port,
+		Endpoint:         args.Endpoint,
+		Region:           args.Region,
+		AccessKey:        args.AccessKey,
+		SecretKey:        promcfg.Secret(args.SecretKey),
+		Profile:          args.Profile,
+		RoleARN:          args.RoleARN,
+		RefreshInterval:  model.Duration(args.RefreshInterval),
+		Port:             args.Port,
+		HTTPClientConfig: *args.HTTPClientConfig.Convert(),
 	}
 	for _, f := range args.Filters {
 		cfg.Filters = append(cfg.Filters, &promaws.EC2Filter{

component/discovery/aws/ec2_test.go

@@ -0,0 +1,29 @@
+package aws
+
+import (
+	"net/url"
+	"testing"
+
+	"github.com/grafana/agent/component/common/config"
+	"github.com/stretchr/testify/require"
+	"gotest.tools/assert"
+)
+
+func TestConvert(t *testing.T) {
+	// parse example proxy
+	u, err := url.Parse("http://example:8080")
+	require.NoError(t, err)
+	httpClientConfig := config.DefaultHTTPClientConfig
+	httpClientConfig.ProxyURL = config.URL{URL: u}
+
+	// example configuration
+	riverArgs := EC2Arguments{
+		Region:           "us-east-1",
+		HTTPClientConfig: httpClientConfig,
+	}
+
+	// ensure values are set
+	promArgs := riverArgs.Convert()
+	assert.Equal(t, "us-east-1", promArgs.Region)
+	assert.Equal(t, "http://example:8080", promArgs.HTTPClientConfig.ProxyURL.String())
+}