Skip to content

Commit

Permalink
Makefile: support release candidate versions (#1566)
Browse files Browse the repository at this point in the history
$IMAGE_BRANCH_TAG must not be an empty string for building images. This
defaults $IMAGE_BRANCH_TAG for release candidates to be the same as
$RELEASE_TAG.

This will redundantly cause the image to be tagged twice as
$RELEASE_TAG, but will avoid build errors.
  • Loading branch information
rfratto authored Apr 5, 2022
1 parent 2e75293 commit 56140bc
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ else
IMAGE_TAG ?= $(RELEASE_TAG)

# If $RELEASE_TAG is from a stable release we want to update :latest instead of
# a branch.
# a branch. Otherwise, we want to re-use the versioned tag name.
ifeq (,$(findstring -rc.,$(RELEASE_TAG)))
IMAGE_BRANCH_TAG = latest
else
IMAGE_BRANCH_TAG = $(RELEASE_TAG)
endif

endif
Expand Down

0 comments on commit 56140bc

Please sign in to comment.