Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login by waiting a little #49

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix login by waiting a little #49

merged 1 commit into from
Dec 4, 2024

Conversation

maurerle
Copy link
Collaborator

@maurerle maurerle commented Dec 4, 2024

we need to reload the page, by navigating to the base url once more

closes #46

I tested this with a local dashboard.
It failed without sleeping a while.
I guess that .5 seconds is enough for remote dashboards as well

* we need to reload the page, by navigating to the base url once more
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (a002812) to head (3574e6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files           3        3           
  Lines         192      192           
=======================================
  Hits          172      172           
  Misses         20       20           
Flag Coverage Δ
unittests 89.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack! I guess it would be better to have Marionette wait for a DOM element, but if that works for you now, let's just go ahead with it.

@maurerle maurerle merged commit 4e0c5ee into main Dec 4, 2024
5 checks passed
@maurerle maurerle deleted the fix_login branch December 4, 2024 20:44
@maurerle maurerle restored the fix_login branch December 4, 2024 20:44
@maurerle maurerle deleted the fix_login branch December 4, 2024 20:44
@amotl
Copy link
Contributor

amotl commented Dec 4, 2024

Version 0.9.0 has been released, including your improvements. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recording Grafana panels that need a login
2 participants