Enforce java 11 due to openapi generator compatibility #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welandaz
approved these changes
Aug 29, 2023
c00ler
approved these changes
Aug 29, 2023
c00ler
reviewed
Sep 6, 2023
Co-authored-by: Alexey Venderov <[email protected]> Signed-off-by: Szava Maczika <[email protected]>
README.md
Outdated
| @@ -15,6 +15,9 @@ $ ./gradlew install | |||
| This builds and installs the program into `build/install/gradle-enterprise-api-samples`. | |||
| You can use the `build/install/gradle-enterprise-api-samples/bin/gradle-enterprise-api-samples` script to run the sample. | |||
|
|
|||
| ### Note on JDK11 | |||
|
|
|||
| Due to a change in the [openapi generator project](https://github.com/gradle/gradle-enterprise-api-samples/pull/74) JDK 11 is required to build the samples. The clients still work using java 8 | |||
There was a problem hiding this comment.
Shouldn't that be 'JDK 8'? Also, that sentence is missing a period.
There was a problem hiding this comment.
No it's not JDK 8, because running an app does not need a JDK but a JRE, but using JRE would've been kindof weird IMO
sorin-florea
approved these changes
Sep 7, 2023
maczikasz
commented
Sep 7, 2023
Signed-off-by: Szava Maczika <[email protected]>
etiennestuder
requested changes
Sep 7, 2023
etiennestuder
approved these changes
Sep 7, 2023
maczikasz
deleted the
maczikasz/dependabot/gradle/org.openapi.generator-7.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPITools/openapi-generator#15553
https://github.com/gradle/ge/issues/27007