Add support for gitlab tags and custom values #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds run on GitLab CI via Docker containers might not have `git` installed, use the equivalent values from the environment instead
bdemers
commented
Dec 11, 2024
| "Git commit id", | ||
| "Git commit id short", | ||
| gitCommitShortId)); | ||
| envVariable("CI_REPOSITORY_URL").ifPresent(gitRepo -> |
There was a problem hiding this comment.
This could instead by the project URL, which is the browser URL, CI_REPOSITORY_URL is the git remote URL)
Suggested change
| envVariable("CI_REPOSITORY_URL").ifPresent(gitRepo -> | |
| projectUrl.ifPresent(gitRepo -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds run on GitLab CI via Docker containers might not have
gitinstalled, use the equivalent values from the environment insteadI didn't run this exact code, instead I tested it out via a
.mvn/develocity-custom-user-data.groovy