Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid saving build-results for cache cleanup #520

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Jan 20, 2025

The Gradle build used to perform cache-cleanup will run in the context of init-scripts
provided by the action, including those that collect build-results.
In some circumstances this can lead to unexpected results, such as saving configuration-cache
entries for cache cleanup executions.

With this change, build results will not be captured for cache-cleanup builds.

@bigdaz bigdaz force-pushed the dd/no-cleanup-config-cache branch 3 times, most recently from 27abf2e to f108fce Compare January 20, 2025 23:19
The Gradle build used to perform cache-cleanup will run in the context of init-scripts
provided by the action, including those that collect build-results.
In some circumstances this can lead to unexpected results, such as saving configuration-cache
entries for cache cleanup executions.

With this change, build results will not be captured for cache-cleanup builds.
@bigdaz bigdaz force-pushed the dd/no-cleanup-config-cache branch from f108fce to 668425d Compare January 20, 2025 23:26
@bigdaz bigdaz changed the title Avoid saving config-cache entries for cache cleanup Avoid saving build-results for cache cleanup Jan 20, 2025
@bigdaz bigdaz requested a review from a team January 20, 2025 23:39
Copy link
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.12 Build Scan published

@bigdaz bigdaz merged commit e4f3569 into main Jan 21, 2025
122 checks passed
@bigdaz bigdaz deleted the dd/no-cleanup-config-cache branch January 21, 2025 16:45
@bigdaz bigdaz added this to the v4.3.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants