-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate wrappers for all Gradle nightlies published at https://services.gradle.org/distributions-snapshots/ #281
Comments
The services.gradle.org versions API only provides details on latest nightly (and release nightly), so wouldn't the API need to be enhanced first? Is there another source for this? |
While not ideal, it should be possible to extract the wrapper checksums by traversing the directory listing at https://services.gradle.org/distributions-snapshots/ |
Do you mean by reading the HTML and looking for the links? Or is there another way? I'd have thought that would be a little fragile, and failures to parse would have to fail the action if validation has been enabled (though given it's for nightlies failures are relatively lower impact, and any issue would surely be fixed quickly especially if it's impacting Gradle's own builds). I'm not volunteering to build a PR since I'm unfamiliar with TypeScript but the pointers might help someone with the right experience. It would be nice to unblock #12 for v4. |
Yes, that's what I meant. The HTML is a generated directory listing and should be generally stable over time. We would only fail the build if all of the following were true:
I think this would be acceptable. I'm not sure about getting #14 into |
By slurping the checksum URLs from https://services.gradle.org/distributions-snapshots/ we can include these unpublished wrapper checksums in validation. Fixes #281
This is a prerequisite for using the action in any repository that makes use of nightlies.
This is a prerequisite for dogfooding in the
gradle
org which makes heavy use of nightlies.Currently, the action consumes https://services.gradle.org/versions/all which contains information about the latest nightly and the latest release nightly only. All other nightlies are missing.
The text was updated successfully, but these errors were encountered: