Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docstring for the the "variant" parameter in gr.Button #9806

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

fadingNA
Copy link
Contributor

@fadingNA fadingNA commented Oct 22, 2024

Description

Align parameter document of button api reference

🎯 PRs Should Target Issues

Closes: #9787

Tests

All tests pass.

@fadingNA
Copy link
Contributor Author

@abidlabs I made PR for you to review

Thank you

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 22, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/eebf4a82b06f829611e94dd8c6a7452f0485f1bf/gradio-5.3.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@eebf4a82b06f829611e94dd8c6a7452f0485f1bf#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/eebf4a82b06f829611e94dd8c6a7452f0485f1bf/gradio-client-1.7.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/eebf4a82b06f829611e94dd8c6a7452f0485f1bf/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 22, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

update docstring for the the "variant" parameter in gr.Button

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used this as an opportunity to make some other tweaks to the docstrings, but this looks good. Thanks @fadingNA!

@abidlabs abidlabs enabled auto-merge (squash) October 22, 2024 22:05
@fadingNA
Copy link
Contributor Author

used this as an opportunity to make some other tweaks to the docstrings, but this looks good. Thanks @fadingNA!

Thank you so much @abidlabs

@abidlabs abidlabs changed the title update button varaint of hugginface update docstring for the the "variant" parameter in gr.Button Oct 22, 2024
@abidlabs abidlabs merged commit b538bda into gradio-app:main Oct 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons of type 'huggingface' appear Black
3 participants