Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create app.py #5842

Closed
wants to merge 1 commit into from
Closed

Conversation

sambhavnoobcoder
Copy link

created complex demo demonstrating capabilities of gradio to handle large workloads , fixes issue #5217

Description

issue required a demo demonstrating the capability of gradio to handle complex apps with thousands of components and inferences . this pr closes the issue .

Closes: #( #5217)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

created complex demo demonstrating capabilities of gradio to handle large workloads , fixes issue  gradio-app#5217
@abidlabs
Copy link
Member

Hi @sambhavnoobcoder! Thanks for the contribution, but this app does not capture several sources of complexity that are present in complex Gradio apps, such as the Automatic1111 Web UI.

  1. It only has single event --> the complex app should have hundreds of events (they can all be mock events but there should many different
  2. It should use gr.Blocks not gr.Interface since gr.Blocks offers more level of customization, etc.
  3. There should be many different tabs --> tabs hide and display content on a page, which is something we can measure the performance of

Thinking about this some more, I wonder if the Gradio Theme Builder could serve the purposes of this complex app, wdyt @pngwn @aliabid94?

@abidlabs
Copy link
Member

I'll go ahead and close this given the points I raised above

@abidlabs abidlabs closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants