Fix the embedded Lite apps in the docs #10488
Open
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-js.md to display the embedded Gradio-Lite apps properly
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/211698e5d98fcc8ed556c565ae9ff76484e78163/gradio-5.14.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@211698e5d98fcc8ed556c565ae9ff76484e78163#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/211698e5d98fcc8ed556c565ae9ff76484e78163/gradio-client-1.10.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/211698e5d98fcc8ed556c565ae9ff76484e78163/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
whitphx
changed the title
|
I assume this is ready for a review @whitphx? |
|
You are right, sorry I forgot to switch the state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The embedded
<gradio-lite>apps' style is broken as below, and 6bb14ca fixes it.2178f48 is a related refactoring: I found that each component is loading
lite.cssin each Svelte file (and 6bb14ca did the same in the document markdown file), solite.jsshould also be loaded by each component, instead of being loaded globally in+layout.svelte.