Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore chat interface full height #10314

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Conversation

aliabid94
Copy link
Collaborator

Chatbot stopped taking full height in ChatInterface, now back if save_history=False. Still need to figure out how to expand height when chat history is enabled, but that's harder so will do later.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 8, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/3dc2084e186cca2263caf962afea66fa2bb23c0d/gradio-5.10.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3dc2084e186cca2263caf962afea66fa2bb23c0d#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/3dc2084e186cca2263caf962afea66fa2bb23c0d/gradio-client-1.9.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/3dc2084e186cca2263caf962afea66fa2bb23c0d/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 8, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch

With the following changelog entry.

Restore chat interface full height

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Jan 8, 2025

Fixed one more issues where additional inputs and table of examples should show under the main chatbot if save history is enabled, e.g. test with:

import gradio as gr

gr.ChatInterface(lambda x,y,z:x, save_history=True, type="messages", additional_inputs=["textbox"]).launch()

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aliabid94 aliabid94 merged commit 84e72e4 into main Jan 8, 2025
22 checks passed
@aliabid94 aliabid94 deleted the restore_chatinterface_full_height branch January 8, 2025 20:36
dawoodkhan82 pushed a commit that referenced this pull request Jan 13, 2025
* changes

* add changeset

* changes

* fix position of additional examples

* Update shaky-shirts-hammer.md

---------

Co-authored-by: Ali Abid <[email protected]>
Co-authored-by: gradio-pr-bot <[email protected]>
Co-authored-by: Abubakar Abid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants