-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a run_examples_on_click
parameter to gr.ChatInterface
mirroring the the run_on_click
parameter in gr.Examples
#10109
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/43acdc2c90952f63fb8f7ccc6122a1615def004a/gradio-5.8.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@43acdc2c90952f63fb8f7ccc6122a1615def004a#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/43acdc2c90952f63fb8f7ccc6122a1615def004a/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/43acdc2c90952f63fb8f7ccc6122a1615def004a/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
run_examples_on_click
parameter to gr.ChatInterface
mirroring the the run_on_click
parameter in gr.Examples
Thanks yet again @freddyaboulton! Will take a look at that issue |
Oh so the issue is actually with the default behavior hmm |
Thanks! Basically LGTM, but I noticed that the undo button is not working correctly for multimodal examples out.mp4 |
Dang okay thanks for flagging @hysts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the undo issue is not introduced in this PR, I guess it can be fixed in another PR. So I'll approve this PR for now.
Let me see if I can fix it real quick |
Fixed the undo bug and added two more end-to-end tests to test. We've added quite a few e2e tests for chatinterface, but I think we need them all since there are so many different message types and configuration paths. When we have bandwidth, we can figure out ways to run them faster. |
Thanks @freddyaboulton and @hysts for the thorough reviews, I'll merge this in when CI is green. |
😅 taking a bit longer than I thought but doing some secondary cleanup as well |
Whew finally ready. Will merge this in tomorrow if there are no objections! |
Small PR that adds a
run_examples_on_click
parameter on togr.ChatInterface
, closes: #10103Two examples to test with:
Also fixes: #10105