Refactor settings to use interface & add extrusion amount reporting #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o settings-interface-refactor # Conflicts: # generators/ThreeAxisPrintGenerator.cs
|
I will reimplement this at some point in a cleaner branch now that I have a better understanding and system for making changes. Closing this PR. |
gregmeess
pushed a commit
to SutroMachine/gsSlicer
that referenced
this pull request
Feb 26, 2020
Add optional z-lift on travel move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to minimize it, but a bunch of white space formatting snuck in; I assume the style guidelines should be 4 spaces instead of tabs?
Unfortunately the extrusion reporting got tangled up in this settings refactor, but if desired I can recreate it on it's own branch from master.
Since I wasn't originally planning on merging this back upstream, I made some changes around settings replacing
CloneAs<T>withCopyFrom; I'm guessing this may be breaking for Cotangent.