Skip to content

Commit

Permalink
[Explore view] Fix extra data fetch when user clicks Run Query (apach…
Browse files Browse the repository at this point in the history
  • Loading branch information
Grace Guo authored Aug 20, 2019
1 parent c97a71b commit 319c1df
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions superset/assets/src/explore/components/ExploreViewContainer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ class ExploreViewContainer extends React.Component {

/* eslint no-unused-vars: 0 */
componentDidUpdate(prevProps, prevState) {
this.triggerQueryIfNeeded();

const changedControlKeys = this.findChangedControlKeys(prevProps.controls, this.props.controls);
if (this.hasDisplayControlChanged(changedControlKeys, this.props.controls)) {
this.addHistory({});
Expand Down Expand Up @@ -213,17 +211,6 @@ class ExploreViewContainer extends React.Component {
);
}

triggerQueryIfNeeded() {
if (this.props.chart.triggerQuery && !this.hasErrors()) {
this.props.actions.postChartFormData(
this.props.form_data,
false,
this.props.timeout,
this.props.chart.id,
);
}
}

addHistory({ isReplace = false, title }) {
const { payload } = getExploreUrlAndPayload({ formData: this.props.form_data });
const longUrl = getExploreLongUrl(this.props.form_data, null, false);
Expand Down

0 comments on commit 319c1df

Please sign in to comment.