Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass classname to dense card #1062

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: pass classname to dense card #1062

merged 2 commits into from
Sep 25, 2024

Conversation

pyphilia
Copy link
Contributor

ref graasp/graasp-builder#1433

The solution is to keep track of cards, which is done through a class for dense cards, but not non-dense cards.

@pyphilia pyphilia requested a review from ReidyT September 24, 2024 13:25
@pyphilia pyphilia self-assigned this Sep 24, 2024
ReidyT
ReidyT approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, LGTM 🌞 Maybe just add a comment to explain why we pass the class?

@pyphilia pyphilia enabled auto-merge September 25, 2024 11:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit d581f2f Sep 25, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 25, 2024
Merged
@spaenleh spaenleh deleted the card-classname branch October 1, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

Assignees

@pyphilia pyphilia

Labels
v5.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @ReidyT