Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cannot enroll failure message #522

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: cannot enroll failure message #522

merged 2 commits into from
Sep 13, 2024

Conversation

Defferrard
Copy link
Contributor

No description provided.

@Defferrard Defferrard self-assigned this Sep 11, 2024
@Defferrard Defferrard linked an issue Sep 11, 2024 that may be closed by this pull request
Failure Message Cannot Enroll Item Login Schema #521
Closed
spaenleh
spaenleh previously requested changes Sep 11, 2024
View reviewed changes
src/langs/en/messages.json Outdated Show resolved Hide resolved
pyphilia
pyphilia approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but take a good look to my comments!

src/langs/en/messages.json Outdated Show resolved Hide resolved
src/langs/en/messages.json Outdated Show resolved Hide resolved
@Defferrard Defferrard force-pushed the 521-failure-message-cannot-enroll-item-login-schema branch from ddfbb97 to 9c0960a Compare September 11, 2024 12:27
@Defferrard Defferrard requested a review from spaenleh September 11, 2024 12:27
ReidyT
ReidyT reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and your changes! I'm agreeing with @pyphilia about the difference between the name and the text. I know you changed it, but I'm still thinking there is a difference. What do you think?

src/langs/en/messages.json Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge September 13, 2024 08:24
@pyphilia pyphilia dismissed spaenleh’s stale review September 13, 2024 08:24

this pr got enough reviews

@pyphilia pyphilia added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 95523fe Sep 13, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 13, 2024
Merged
@spaenleh spaenleh deleted the 521-failure-message-cannot-enroll-item-login-schema branch October 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@Defferrard Defferrard

Labels
v1.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure Message Cannot Enroll Item Login Schema
4 participants
@Defferrard @pyphilia @spaenleh @ReidyT