Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 sign in success #100

Merged
merged 7 commits into from
Feb 14, 2023
Merged

99 sign in success #100

merged 7 commits into from
Feb 14, 2023

Conversation

pyphilia
Copy link
Contributor

close #99

@pyphilia pyphilia requested a review from spaenleh February 13, 2023 12:13
@pyphilia pyphilia self-assigned this Feb 13, 2023
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📩 Looks good, just made a few suggestions to the translations.

Are we also adding a different text for when you first sign up ? Since new users may expect to be able to directly access the platform ? Something like: "Nice to see you ! Check you email inbox, we sent you an email with a login link. Click the link in the email to login !"

And maybe we could say "Welcome back " as the biggest text in the splash screen ? Just some thoughts :)

src/langs/en/auth.json Outdated Show resolved Hide resolved
src/langs/en/auth.json Outdated Show resolved Hide resolved
src/langs/en/auth.json Outdated Show resolved Hide resolved
src/langs/fr/auth.json Outdated Show resolved Hide resolved
src/langs/fr/auth.json Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from spaenleh February 13, 2023 14:57
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice ! LGTM ! 🌵

@pyphilia pyphilia merged commit 2b09bf2 into main Feb 14, 2023
@pyphilia pyphilia deleted the 99-sign-in-success branch February 14, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sign in success translations
2 participants