Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new member storage items type #589

Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat: add new member storage items type #589

merged 3 commits into from
Jul 19, 2024

Conversation

mariembencheikh
Copy link
Contributor

@mariembencheikh mariembencheikh commented Jul 19, 2024 •
edited
Loading

@mariembencheikh mariembencheikh self-assigned this Jul 19, 2024
@mariembencheikh mariembencheikh added the feature New feature or request label Jul 19, 2024
@mariembencheikh mariembencheikh linked an issue Jul 19, 2024 that may be closed by this pull request
Add new type definition for member storage items #588
Closed
Defferrard
Defferrard reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Defferrard Defferrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! I just saw an incoherence with the specification, not sure if it is intended

src/member/member.ts Outdated Show resolved Hide resolved
ReidyT
ReidyT approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it looks good to me 😆 I just agree with @Defferrard concerning the difference with the specification.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Defferrard
Defferrard approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Defferrard Defferrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariembencheikh mariembencheikh added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit e016076 Jul 19, 2024
3 checks passed
@graasper graasper mentioned this pull request Jul 19, 2024
Merged
@pyphilia pyphilia deleted the 588-add-new-type-definition-for-member-storage-items branch August 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@Defferrard Defferrard Defferrard approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@mariembencheikh mariembencheikh

Labels
feature New feature or request v4.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new type definition for member storage items
3 participants
@mariembencheikh @Defferrard @ReidyT