Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guest and account types #585

Merged
merged 5 commits into from
Aug 22, 2024
Merged

feat: add guest and account types #585

merged 5 commits into from
Aug 22, 2024

Conversation

Defferrard
Copy link
Contributor

No description provided.

@Defferrard Defferrard linked an issue Jul 18, 2024 that may be closed by this pull request
@Defferrard Defferrard force-pushed the 568-new-membertype branch 5 times, most recently from f93c4fc to 6d21f87 Compare July 19, 2024 09:19
@spaenleh spaenleh force-pushed the 568-new-membertype branch from 6d21f87 to cd905fa Compare July 29, 2024 09:19
@Defferrard Defferrard force-pushed the 568-new-membertype branch from cd905fa to 746899d Compare July 29, 2024 13:07
src/member/factory.ts Outdated Show resolved Hide resolved
@Defferrard Defferrard force-pushed the 568-new-membertype branch 4 times, most recently from c494365 to fb45dad Compare July 31, 2024 05:30
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, LGTM! I just let some comments 🎃

src/itemMembership/factory.ts Outdated Show resolved Hide resolved
src/itemLogin/factory.ts Outdated Show resolved Hide resolved
src/member/factory.ts Outdated Show resolved Hide resolved
src/member/member.ts Outdated Show resolved Hide resolved
src/member/member.ts Outdated Show resolved Hide resolved
src/member/member.ts Outdated Show resolved Hide resolved
src/member/member.ts Outdated Show resolved Hide resolved
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@spaenleh spaenleh marked this pull request as ready for review August 21, 2024 11:28
@spaenleh spaenleh force-pushed the 568-new-membertype branch from dcdb20a to 4ebc452 Compare August 21, 2024 11:28
Copy link

@spaenleh spaenleh added the feature New feature or request label Aug 21, 2024
@spaenleh spaenleh added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit d320bff Aug 22, 2024
3 checks passed
@spaenleh spaenleh deleted the 568-new-membertype branch August 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v4.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New MemberType
3 participants