Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove qs dep #307

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: remove qs dep #307

merged 1 commit into from
Oct 26, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 26, 2023

Note
It was safe to remove the resolutions as we are now depending on higher versions of those packages:

Full dependencies for minimist
❯ yarn why minimist 
└─ @commitlint/read@npm:18.1.0
   └─ minimist@npm:1.2.8 (via npm:^1.2.6)
Full dependencies for @babel/core
❯ yarn why @babel/core
├─ @jest/transform@npm:29.7.0
│  └─ @babel/core@npm:7.23.2 (via npm:^7.11.6)
│
├─ istanbul-lib-instrument@npm:5.1.0
│  └─ @babel/core@npm:7.23.2 (via npm:^7.12.3)
│
├─ istanbul-lib-instrument@npm:6.0.0
│  └─ @babel/core@npm:7.23.2 (via npm:^7.12.3)
│
├─ jest-config@npm:29.7.0
│  └─ @babel/core@npm:7.23.2 (via npm:^7.11.6)
│
├─ jest-config@npm:29.7.0 [3a6a7]
│  └─ @babel/core@npm:7.23.2 (via npm:^7.11.6)
│
├─ jest-config@npm:29.7.0 [7cdeb]
│  └─ @babel/core@npm:7.23.2 (via npm:^7.11.6)
│
└─ jest-snapshot@npm:29.7.0
   └─ @babel/core@npm:7.23.2 (via npm:^7.11.6)

Package qs was removed as the functionality can be performed using native browser and node APIs.

@spaenleh spaenleh requested a review from pyphilia October 26, 2023 07:03
@spaenleh spaenleh self-assigned this Oct 26, 2023
@spaenleh spaenleh added chore Generic task or chore dependencies Pull requests that update a dependency file labels Oct 26, 2023
src/utils/navigation.ts Show resolved Hide resolved
@spaenleh spaenleh merged commit 3fe0d9c into main Oct 26, 2023
2 checks passed
@spaenleh spaenleh deleted the remove-qs-dep branch November 3, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Generic task or chore dependencies Pull requests that update a dependency file v1.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants