refactor: add item settings with maxWidth

src/services/file/interfaces/extra.ts

@@ -1,6 +1,13 @@
 import { ItemType } from '../../../constants';
 import { UnknownExtra } from '../../../interfaces';
 
+export enum MaxWidth {
+  Small = 'sm',
+  Medium = 'md',
+  Large = 'lg',
+  ExtraLarge = 'xl',
+}
+
 /**
  * @deprecated Use FileItemProperties instead
  */

src/services/items/index.ts

@@ -1 +1,2 @@
 export * from './interfaces/item';
+export * from './interfaces/itemSettings';

src/services/items/interfaces/item.ts

@@ -9,29 +9,12 @@ import { AppItemExtra } from '../../app/';
 import { EtherpadItemExtra } from '../../etherpad';
 import { LocalFileItemExtra, S3FileItemExtra } from '../../file';
 import { H5PItemExtra } from '../../h5p';
-import { CCLicenseAdaptions, Member, OldCCLicenseAdaptations } from '@/index';
-
-export interface ItemSettings {
-  lang?: string;
-  isPinned?: boolean;
-  showChatbox?: boolean;
-  hasThumbnail?: boolean;
-  isResizable?: boolean;
-  isCollapsible?: boolean;
-  enableSaveActions?: boolean;
-  tags?: string[];
-  displayCoEditors?: boolean;
-  ccLicenseAdaption?:
-    | `${CCLicenseAdaptions}`
-    | CCLicenseAdaptions
-    // todo: these are the old licenses, we might remove them at some point.
-    | `${OldCCLicenseAdaptations}`;
-}
-
-export interface EmbeddedLinkItemSettings extends ItemSettings {
-  showLinkIframe?: boolean;
-  showLinkButton?: boolean;
-}
+import {
+  EmbeddedLinkItemSettings,
+  FileItemSettings,
+  ItemSettings,
+} from './itemSettings';
+import { Member } from '@/index';
 
 export interface Item<S = ItemSettings> {
   id: string;
@@ -65,14 +48,14 @@ export type EmbeddedLinkItemType<S = ItemSettings> = {
   extra: EmbeddedLinkItemExtra;
   settings: EmbeddedLinkItemSettings;
 } & Item<S>;
-export type LocalFileItemType<S = ItemSettings> = {
+export type LocalFileItemType = {
   type: `${ItemType.LOCAL_FILE}`;
   extra: LocalFileItemExtra;
-} & Item<S>;
-export type S3FileItemType<S = ItemSettings> = {
+} & Item<FileItemSettings>;
+export type S3FileItemType = {
   type: `${ItemType.S3_FILE}`;
   extra: S3FileItemExtra;
-} & Item<S>;
+} & Item<FileItemSettings>;
 export type ShortcutItemType<S = ItemSettings> = {
   type: `${ItemType.SHORTCUT}`;
   extra: ShortcutItemExtra;
@@ -88,7 +71,7 @@ export type DiscriminatedItem<S = ItemSettings> =
   | FolderItemType<S>
   | H5PItemType<S>
   | EmbeddedLinkItemType<S>
-  | LocalFileItemType<S>
-  | S3FileItemType<S>
+  | LocalFileItemType
+  | S3FileItemType
   | ShortcutItemType<S>
   | EtherpadItemType<S>;

src/services/items/interfaces/itemSettings.ts

@@ -0,0 +1,28 @@
+import { CCLicenseAdaptions, OldCCLicenseAdaptations } from '@/constants';
+import { MaxWidth } from '@/services';
+
+export interface ItemSettings {
+  lang?: string;
+  isPinned?: boolean;
+  showChatbox?: boolean;
+  hasThumbnail?: boolean;
+  isResizable?: boolean;
+  isCollapsible?: boolean;
+  enableSaveActions?: boolean;
+  tags?: string[];
+  displayCoEditors?: boolean;
+  ccLicenseAdaption?:
+    | `${CCLicenseAdaptions}`
+    | CCLicenseAdaptions
+    // todo: these are the old licenses, we might remove them at some point.
+    | `${OldCCLicenseAdaptations}`;
+}
+
+export interface EmbeddedLinkItemSettings extends ItemSettings {
+  showLinkIframe?: boolean;
+  showLinkButton?: boolean;
+}
+
+export interface FileItemSettings extends ItemSettings {
+  maxWidth?: MaxWidth;
+}