Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove member from itemLike #225

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: remove member from itemLike #225

merged 1 commit into from
Oct 26, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Aug 3, 2023

No description provided.

@spaenleh spaenleh linked an issue Aug 3, 2023 that may be closed by this pull request
Fix temporarily remove creator from the ItemLike type because backend does not provide it #188
Closed
@spaenleh spaenleh requested a review from pyphilia August 3, 2023 05:54
@spaenleh spaenleh self-assigned this Aug 3, 2023
@spaenleh spaenleh added the chore Generic task or chore label Aug 3, 2023
pyphilia
pyphilia requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this PR? Instead we can set undefined in the type in case it does not return? In fact we would need other types to define better whether a join is present or not..

@spaenleh spaenleh force-pushed the 188-fix-temporarily-remove-creator-from-the-itemlike-type-because-backend-does-not-provide-it branch from 2d4b5a8 to d4ba5d1 Compare October 26, 2023 15:21
@spaenleh spaenleh merged commit 60f1410 into main Oct 26, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Merged
@spaenleh spaenleh deleted the 188-fix-temporarily-remove-creator-from-the-itemlike-type-because-backend-does-not-provide-it branch November 3, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore v1.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix temporarily remove creator from the ItemLike type because backend does not provide it
2 participants
@spaenleh @pyphilia