Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add item settings with maxWidth #250

Merged
merged 7 commits into from
Aug 30, 2023
Merged

refactor: add item settings with maxWidth #250

merged 7 commits into from
Aug 30, 2023

Conversation

pyphilia
Copy link
Contributor

close #248

@pyphilia pyphilia marked this pull request as ready for review August 23, 2023 15:03
@pyphilia pyphilia requested a review from spaenleh August 23, 2023 15:04
@pyphilia pyphilia self-assigned this Aug 23, 2023
spaenleh
spaenleh requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! See my comments, I have a few questions.

src/services/items/interfaces/item.ts Outdated Show resolved Hide resolved
src/services/file/interfaces/extra.ts Outdated Show resolved Hide resolved
spaenleh
spaenleh requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but juste the enum I don't think it should go in extra.ts.

src/services/file/interfaces/extra.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from spaenleh August 29, 2023 08:41
spaenleh
spaenleh approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! ⚖️

@pyphilia pyphilia merged commit 7164a1c into main Aug 30, 2023
@pyphilia pyphilia deleted the 248-max-width-file branch August 30, 2023 08:20
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add maxWidth to file items
2 participants
@pyphilia @spaenleh