fix: remove extra.app.settings key in item (#623)

graasp · Aug 21, 2024 · b4de950 · b4de950
1 parent 75024e0
commit b4de950
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/src/item/appItem/appItem.factory.test.ts b/src/item/appItem/appItem.factory.test.ts
@@ -12,7 +12,6 @@ describe('AppItemFactory', () => {
   it('Create app item', () => {
     const item = AppItemFactory();
     expect(item.extra.app.url).toContain('http');
-    expect(item.extra.app.settings).toBeDefined();
     expect(item.type).toEqual(ItemType.APP);
   });
   it('Create app item with args', () => {

diff --git a/src/item/appItem/appItem.factory.ts b/src/item/appItem/appItem.factory.ts
@@ -19,7 +19,6 @@ export const AppItemFactory = (
     extra: item.extra ?? {
       [ItemType.APP]: {
         url: faker.internet.url(),
-        settings: {},
       },
     },
   };

diff --git a/src/item/appItem/appItem.ts b/src/item/appItem/appItem.ts
@@ -12,22 +12,19 @@ export type AppItemType<S = ItemSettings> = {
  */
 export type AppItemExtraProperties = {
   url: string;
-  // todo: there currently is nothing stored in the settings. this might change later
-  settings?: unknown;
 };
-export interface AppItemExtra {
+export type AppItemExtra = {
   [ItemType.APP]: AppItemExtraProperties;
-}
+};
 
 export const getAppExtra = <U extends AppItemExtra>(
   extra: U,
 ): U[typeof ItemType.APP] => extra[ItemType.APP];
 
 export const buildAppExtra = ({
   url,
-  settings = {},
 }: AppItemExtraProperties): AppItemExtra => ({
-  [ItemType.APP]: { url, settings },
+  [ItemType.APP]: { url },
 });
 
 /**