Skip to content

Commit

Permalink
fix: remove displayName (#710)
Browse files Browse the repository at this point in the history
* fix: remove displayName

* chore: remove husky shebang
  • Loading branch information
spaenleh authored Nov 21, 2024
1 parent fd3938d commit 705efc7
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 21 deletions.
3 changes: 0 additions & 3 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no-install commitlint --edit "$1"
3 changes: 0 additions & 3 deletions .husky/post-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

git status
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn pre-commit
3 changes: 0 additions & 3 deletions .husky/pre-push
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn lint
yarn build
1 change: 0 additions & 1 deletion src/item/baseItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { Member } from '@/member/member.js';
export type Item<S = ItemSettings> = {
id: string;
name: string;
displayName: string;
description: string | null;
path: string;
settings: S;
Expand Down
6 changes: 0 additions & 6 deletions src/item/factory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,6 @@ describe('Base Item Factory', () => {
const item1 = PartialItemFactory({});
expect(item1.settings.hasThumbnail).toBeFalsy();
});

it('Returns correct default displayName', () => {
const item = PartialItemFactory({});
expect(item.displayName).toBeDefined();
expect(typeof item.displayName).toBe('string');
});
});

describe('Packed Item Factory', () => {
Expand Down
2 changes: 0 additions & 2 deletions src/item/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export type ItemFactoryOutputType<IT extends DiscriminatedItem> = Pick<
IT,
| 'id'
| 'name'
| 'displayName'
| 'description'
| 'path'
| 'settings'
Expand Down Expand Up @@ -54,7 +53,6 @@ export const PartialItemFactory = <IT extends DiscriminatedItem>(
updatedAt,
path,
name,
displayName: item.displayName ?? name,
description: item.description ?? faker.lorem.text(),
settings:
item.settings ??
Expand Down

0 comments on commit 705efc7

Please sign in to comment.