Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add password status hook #958

Merged
merged 5 commits into from
Oct 11, 2024
Merged

feat: add password status hook #958

merged 5 commits into from
Oct 11, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 8, 2024

Adds a hook to get the status of the password.

@pyphilia pyphilia requested review from spaenleh and ReidyT October 8, 2024 13:20
@pyphilia pyphilia self-assigned this Oct 8, 2024
@pyphilia pyphilia added the feature New feature or request label Oct 8, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think it is fine like that, but I was not sure we would need to have a separate /member/password folder for this single query. I think it is good that it is organised, I am just questioning whether it was worth it for this simple feature. Anyway :)

src/member/password/api.ts Show resolved Hide resolved
src/member/password/hooks.test.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia force-pushed the password-status-hook branch from 4acb0a8 to 3616a78 Compare October 11, 2024 12:56
Copy link

@pyphilia pyphilia enabled auto-merge October 11, 2024 12:59
@pyphilia pyphilia added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit e1542e4 Oct 11, 2024
3 checks passed
@pyphilia pyphilia deleted the password-status-hook branch October 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants