Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: most used apps hook #747

Merged
merged 13 commits into from
May 15, 2024
Merged

feat: most used apps hook #747

merged 13 commits into from
May 15, 2024

Conversation

ztlee042
Copy link
Contributor

@ztlee042 ztlee042 commented Apr 26, 2024 •
edited
Loading

#746

In this PR:

  • a useMostUsedApps hook is added

@ztlee042 ztlee042 self-assigned this Apr 29, 2024
@ztlee042 ztlee042 marked this pull request as ready for review April 30, 2024 09:44
@ztlee042 ztlee042 requested a review from spaenleh April 30, 2024 09:44
pyphilia
pyphilia approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to change one key, otherwise LGTM!

src/api/apps.ts Outdated Show resolved Hide resolved
@ztlee042 ztlee042 requested a review from pyphilia May 1, 2024 13:02
spaenleh
spaenleh requested changes May 2, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a change needed for the key and we will be good to go !

src/config/keys.ts Outdated Show resolved Hide resolved
src/hooks/apps.ts Outdated Show resolved Hide resolved
src/hooks/apps.ts Outdated Show resolved Hide resolved
@ztlee042 ztlee042 requested a review from spaenleh May 2, 2024 07:56
spaenleh
spaenleh approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, you just have a small formatting issue. Run yarn prettier:write to fix.

@spaenleh spaenleh force-pushed the 746-most-used-apps branch from f981d31 to 81f63f3 Compare May 6, 2024 07:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 1b5fb17 May 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@spaenleh spaenleh deleted the 746-most-used-apps branch May 28, 2024 07:47
@spaenleh spaenleh mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@ztlee042 ztlee042

Labels
v3.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztlee042 @pyphilia @spaenleh