Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28/fix edit item #33

Merged
merged 3 commits into from
Jul 23, 2021
Merged

28/fix edit item #33

merged 3 commits into from
Jul 23, 2021

Conversation

pyphilia
Copy link
Contributor

close #28

@pyphilia pyphilia added this to the Sprint 4 milestone Jul 22, 2021
@pyphilia pyphilia requested a review from juancarlosfarah July 22, 2021 08:04
@pyphilia pyphilia self-assigned this Jul 22, 2021
Copy link
Member

@juancarlosfarah juancarlosfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Just a quick question in there.

const previousItems = {
parent: await mutateParentChildren({
childPath: newItem.path,
childPath: prevItem.get('path'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to factor out path as some sort of PATH_KEY constant?

@pyphilia pyphilia merged commit f92e9f6 into main Jul 23, 2021
@pyphilia pyphilia deleted the 28/fixEditItem branch July 23, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Item optimistic mutation saves only part of the item
2 participants