fix: split get many publish info, no settled for many calls (#278)

* fix: split get many publish info, no settled for many calls * refactor: remove settled callback for async calls * refactor: fix delete mutation onMutation
graasp · Jun 13, 2023 · adc09eb · adc09eb
1 parent 64242b7
commit adc09eb
Show file tree

Hide file tree

Showing 6 changed files with 84 additions and 878 deletions.
diff --git a/src/api/axios.ts b/src/api/axios.ts
@@ -75,13 +75,13 @@ export const splitRequestByIds = <T>(
   ).then((responses) => {
     // only get request returns
     // todo: not ideal..
-    if (!responses[0] || !responses[0]?.data) {
+    if (responses.every((r: any) => !r?.data)) {
       return null;
     }
 
     const result = responses.reduce(
       (prev, d) => ({
-        data: { ...prev.data, ...d.data },
+        data: { ...prev.data, ...(d.data ?? {}) },
         errors: prev.errors.concat(d.errors),
       }),
       { data: {}, errors: [] },

diff --git a/src/api/itemPublish.ts b/src/api/itemPublish.ts
@@ -1,4 +1,4 @@
-import { Item, UUID } from '@graasp/sdk';
+import { Item, ItemPublished, ResultOf, UUID } from '@graasp/sdk';
 
 import { QueryClientConfig } from '../types';
 import configureAxios, { verifyAuthentication } from './axios';
@@ -40,7 +40,7 @@ export const getItemPublishedInformation = async (
 export const getManyItemPublishedInformations = async (
   ids: UUID[],
   { API_HOST }: QueryClientConfig,
-) =>
+): Promise<ResultOf<ItemPublished>> =>
   axios
     .get(`${API_HOST}/${buildManyGetItemPublishedInformationsRoute(ids)}`)
     .then(({ data }) => data);

diff --git a/src/hooks/itemPublish.ts b/src/hooks/itemPublish.ts
@@ -1,14 +1,20 @@
 import { List } from 'immutable';
 import { useQuery, useQueryClient } from 'react-query';
 
-import { ItemPublished, UUID, convertJs } from '@graasp/sdk';
+import {
+  ItemPublished,
+  MAX_TARGETS_FOR_READ_REQUEST,
+  UUID,
+  convertJs,
+} from '@graasp/sdk';
 import {
   ItemPublishedRecord,
   ItemRecord,
   ResultOfRecord,
 } from '@graasp/sdk/frontend';
 
 import * as Api from '../api';
+import { splitRequestByIds } from '../api/axios';
 import { UndefinedArgument } from '../config/errors';
 import {
   buildItemPublishedInformationKey,
@@ -85,8 +91,11 @@ export default (queryConfig: QueryClientConfig) => {
       return useQuery({
         queryKey: buildManyItemPublishedInformationsKey(args.itemIds),
         queryFn: (): Promise<ResultOfRecord<ItemPublished>> =>
-          Api.getManyItemPublishedInformations(args.itemIds, queryConfig).then(
-            (data) => convertJs(data),
+          splitRequestByIds<ItemPublished>(
+            args.itemIds,
+            MAX_TARGETS_FOR_READ_REQUEST,
+            (chunk) => Api.getManyItemPublishedInformations(chunk, queryConfig),
+            true,
           ),
         onSuccess: async (publishedData) => {
           // save items in their own key