Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oer info page (to be done) #612

Merged
merged 4 commits into from
May 1, 2024
Merged

feat: add oer info page (to be done) #612

merged 4 commits into from
May 1, 2024

Conversation

pyphilia
Copy link
Contributor

close #567

Screenshot 2024-04-29 at 15 38 06 Screenshot 2024-04-29 at 15 38 20 Screenshot 2024-04-29 at 15 38 34 Screenshot 2024-04-29 at 15 38 42

@pyphilia pyphilia self-assigned this Apr 29, 2024
@pyphilia pyphilia added the feature New feature or request label Apr 29, 2024
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Really like the video frames you created. I propose to extract some of the OER page sections into local components to ease the reading of the main component.

Maybe the references could be added inside the video frames so it is easy to click ? Otherwise thank you very much for the amazing work ! 💪

src/components/collection/oer/VideoWithCC.tsx Outdated Show resolved Hide resolved
src/components/collection/oer/VideoWithCC.tsx Show resolved Hide resolved
src/components/collection/oer/VideoWithCC.tsx Outdated Show resolved Hide resolved
src/components/collection/oer/VideoWithCC.tsx Outdated Show resolved Hide resolved
src/components/common/CreativeCommons.tsx Outdated Show resolved Hide resolved
src/components/common/CreativeCommons.tsx Outdated Show resolved Hide resolved
src/components/common/TwitterButton.tsx Outdated Show resolved Hide resolved
src/components/pages/OERInformation.tsx Show resolved Hide resolved
src/components/pages/OERInformation.tsx Show resolved Hide resolved
src/components/pages/OERInformation.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia mentioned this pull request May 1, 2024
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge May 1, 2024 10:17
@pyphilia pyphilia added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit c719b05 May 1, 2024
3 checks passed
@spaenleh spaenleh deleted the 567-oer-info branch July 30, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v1.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page about OER
2 participants