Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add like button for unlogged users and redirect to login #399

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Oct 9, 2023

Screenshot from 2023-10-11 13-14-05

closes #398

@LinaYahya LinaYahya marked this pull request as ready for review October 10, 2023 09:14
@LinaYahya LinaYahya requested a review from spaenleh October 10, 2023 09:14
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR !

Can you add a screenshot for reference ?
We are trying to use "sign in" everywhere instead of login.

I am not sure if the Snackbar is visible enough (users might not look at the bottom of the page) ? Lets see. We can always change it later if it is an issue.

src/langs/en.json Outdated Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from spaenleh October 11, 2023 11:17
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@LinaYahya LinaYahya merged commit 4ace8d1 into main Oct 19, 2023
2 checks passed
@LinaYahya LinaYahya deleted the 398-collection-likeBTN-non-login-user branch October 19, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show like button but gray it out if user is not logged in
2 participants