Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collection views #397

Merged
merged 11 commits into from
Oct 20, 2023
Merged

feat: add collection views #397

merged 11 commits into from
Oct 20, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Oct 9, 2023

@LinaYahya LinaYahya marked this pull request as ready for review October 11, 2023 11:50
@LinaYahya LinaYahya requested a review from spaenleh October 11, 2023 11:50
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👓 Thank you very much for these changes !
Just a few comments. Can you add a screenshot of the collection summary with no views and some views to get an idea ?

Note: We will have to coordinate this deployment with the backend since it depends on the change to the /information endpoint.

package.json Show resolved Hide resolved
src/components/collection/Collection.tsx Outdated Show resolved Hide resolved
src/components/collection/summary/SummaryHeader.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh changed the title Collection views feat: add collection views Oct 11, 2023
@LinaYahya LinaYahya requested a review from spaenleh October 16, 2023 13:54
@LinaYahya LinaYahya merged commit a3d56ec into main Oct 20, 2023
@LinaYahya LinaYahya deleted the collection-views branch October 20, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants